Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multiframe-pointpainting): add multi-sweep pointpainting #2124

Merged

Conversation

tzhong518
Copy link
Contributor

@tzhong518 tzhong518 commented Oct 20, 2022

Signed-off-by: tzhong518 sworgun@gmail.com

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

tzhong518 and others added 2 commits October 20, 2022 18:16
Signed-off-by: tzhong518 <sworgun@gmail.com>
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 10.78% // Head: 10.77% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (5e44c91) compared to base (272f8a2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
- Coverage   10.78%   10.77%   -0.01%     
==========================================
  Files        1179     1179              
  Lines       84449    84467      +18     
  Branches    19795    19795              
==========================================
  Hits         9104     9104              
- Misses      65853    65871      +18     
  Partials     9492     9492              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.76% <0.00%> (ø) Carriedforward from 73ece42

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ion_based_fusion/src/pointpainting_fusion/node.cpp 0.00% <0.00%> (ø)
...sion/src/pointpainting_fusion/preprocess_kernel.cu 0.00% <ø> (ø)
...usion/src/pointpainting_fusion/voxel_generator.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: tzhong518 <sworgun@gmail.com>
…18/autoware.universe into feature/pointpainting_multiframe
@tzhong518 tzhong518 changed the title feat: multiframe-pointpainting feat(multiframe-pointpainting): add multi-sweep pointpainting Oct 21, 2022
@tzhong518 tzhong518 marked this pull request as ready for review October 21, 2022 05:38
…foundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
@yukke42
Copy link
Contributor

yukke42 commented Oct 24, 2022

@tzhong518 Cloud you add pointpainting option to tier4_perception_launch ?
ref: tier4/autoware_launch#426

Signed-off-by: tzhong518 <sworgun@gmail.com>
@tzhong518 tzhong518 requested a review from miursh as a code owner October 25, 2022 01:48
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I verified that it works correctly.
image

Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzhong518 tzhong518 enabled auto-merge (squash) October 28, 2022 02:08
@tzhong518 tzhong518 merged commit dd52915 into autowarefoundation:main Oct 28, 2022
tzhong518 added a commit to tier4/autoware.universe that referenced this pull request Dec 9, 2022
…refoundation#2124)

* feat: multiframe-pointpainting

Signed-off-by: tzhong518 <sworgun@gmail.com>

* ci(pre-commit): autofix

* fix: retrieve changes of classremap

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix(image_projection_based_fusion): fix input to quaternion (autowarefoundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* add: launch files

Signed-off-by: tzhong518 <sworgun@gmail.com>

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…refoundation#2124)

* feat: multiframe-pointpainting

Signed-off-by: tzhong518 <sworgun@gmail.com>

* ci(pre-commit): autofix

* fix: retrieve changes of classremap

Signed-off-by: tzhong518 <sworgun@gmail.com>

* fix(image_projection_based_fusion): fix input to quaternion (autowarefoundation#1933)

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>

* add: launch files

Signed-off-by: tzhong518 <sworgun@gmail.com>

Signed-off-by: tzhong518 <sworgun@gmail.com>
Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants